feat(allowlist): add GraphQL (.graphql/.gql) support#491
Merged
lizhengfeng101 merged 2 commits intoJul 24, 2026
Merged
Conversation
…a#488) Add .graphql/.gql allowlist rows and .graphql/.gql rule-resolution rows asserting a GraphQL rule doc, both RED before the config lands.
Allow .graphql and .gql through the extension allowlist and map them to a dedicated GraphQL review rule covering schema evolution, breaking changes, naming, and schema-visible resource limits. Part of alibaba#470.
Contributor
|
✅ OpenCodeReview: No comments generated. Looks good to me. |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds GraphQL support as a language-group contribution under tracking issue #470 / sub-issue #488.
.graphqland.gqlfiles were skipped by both review paths because they were missing from the extension allowlist. This PR:.graphql/.gql(case-insensitive) viasupported_file_types.json**/*.{graphql,gql}→ a dedicatedgraphql.mdrule doc (schema-first and query/client focus)No Go production logic changes. No exclude patterns (GraphQL has no standard test-file convention per #470 / issue discussion).
Why
After this PR:
Changes
internal/config/allowlist/supported_file_types.json.graphql,.gqlinternal/config/allowlist/allowed_ext_test.gointernal/config/rules/system_rules.json"**/*.{graphql,gql}": "graphql.md"internal/config/rules/rule_docs/graphql.mdinternal/config/rules/system_rules_test.go.graphql/.gqlRule doc focus
Test plan
go test ./internal/config/allowlist/ ./internal/config/rules/make testmake checkgrep -l "Breaking Changes" rule_docs/*→ onlygraphql.mdOut of scope
preview_test.go/scan/coverage_test.go(unit gates cover allowlist+resolve; can add in follow-up if maintainers want)Closes #488
Part of #470